Make a change
that lands.
Small, finished, tested and plain. The same bar applies to everyone, including the people who started it.
The bar
- Finished. No placeholders, no TODOs, no stubs. If something cannot be finished, leave it out and say what is missing.
- Verified. Run it, test it, look at it. Screenshots at 390 and 1440 pixels for anything visual, in both the light pages and the dark Talk page.
- Small. One change per pull request, matching the code around it. Comments say why, not what.
- Honest. Fix the cause of a failure; never weaken a test to make it pass. Every number you add must be reproducible.
Before you open a pull request
One command runs everything: types, the build, every unit suite, the three browser walks against the fresh build, and the security checks.
cd web
PLAYWRIGHT_CORE=/path/to/node_modules/playwright-core/index.mjs bun run test:all
bun run test:all -- --live # also probe the live site
bun run test:security # security checks alone, against the live site
| Layer | What it proves |
|---|---|
| Unit | The engine (352 parity fixtures with the Python engine, binding, questions, comparisons), 21 realistic requests, the studio flow, the inbox and its permission rules, the board reader, the help chatbot, designs and the APIs, each against a mocked model. |
| Browser walks | Studio: rubbish refused, one question at a time with no repeats, the sheet, men-only shop links, voice into the composer. Board: reading, notes on the canvas, every choice. Inbox: a customer and a maker in two tabs, badges, toasts, typing, status, the phone layout. |
| Security | Headers, every function refusing bad and oversized input, prompt injection (also hidden in history), no invented links, no secrets in the shipped scripts, nothing in the database readable or writable without an account, and markup in messages shown as text. |
The browser walks need playwright-core and Microsoft Edge. Screenshots go to a temp folder, never into the repo.
Design rules
White, Google Sans at weight 500 for display type, one accent (#38bdf8), glass only on what floats, generous space. No badges, check-mark lists, emoji icons, nested cards or decorative gradients. Every state is designed: hover, focus, pressed, disabled, loading, empty and error. Motion answers a person's action, and reduced-motion turns it off.
Writing
Copy in plain, active, sentence-case words. Buttons say what happens: Send to a maker, not Submit. Commit messages are short and plain, describing what changed in one line.
Data and safety
Never log what people type. Keep secrets out of code; they live in the deployment's environment. New tables get row-level security before they get data. The Ask guardrails, retrieval threshold and output checks are tested; keep them that way.